feat(prefect-worker): support extra initContainers #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @NiJuFirenzia - thanks for the contribution! Looks like theres just a few linting errors. Once those are fixed, I'll be happy to merge. |
|
And bonus points if you add test(s)! https://github.com/PrefectHQ/prefect-helm/blob/main/charts/prefect-worker/tests/worker_test.yaml |
kayhern
force-pushed
the
add-worker-init-containers
branch
from
a324ba9
to
72e6728
Compare
|
Hi @jamiezieziula and @mitchnielsen, I added a test case for the additional extra containers and fixed the lint error. Let me know if anything else is needed. |
Signed-off-by: Nikhil Jiju <[email protected]>
Signed-off-by: Nikhil Jiju <[email protected]>
NiJuFirenzia
force-pushed
the
add-worker-init-containers
branch
from
72e6728
to
08d90c4
Compare
mitchnielsen
changed the title
mitchnielsen
approved these changes
Oct 25, 2024
|
Thanks for the contribution @NiJuFirenzia! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Providing option to create extra Init Containers for Workers. The Init Containers are set up as optional in addition to the Init Container that is already present in the worker to allow for syncing basejob template. A definition for "extraContainers" has been added.
Resolves #393